Checkstyle Results
The following document contains the results of Checkstyle. 
Files
Rules
| Rules | Violations | Severity |
|---|---|---|
JavadocPackage
| 4 |  Error |
| NewlineAtEndOfFile | 0 | Error |
| Translation | 0 | Error |
| FileLength | 0 | Error |
FileTabCharacter
| 1 | Error |
RegexpSingleline
| 63 | Error |
| JavadocMethod | 27 | Error |
| JavadocType | 1 | Error |
| JavadocVariable | 8 | Error |
| JavadocStyle | 18 | Error |
| ConstantName | 0 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 1 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 0 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 2 | Error |
| LineLength | 101 | Error |
| MethodLength | 0 | Error |
| ParameterNumber | 0 | Error |
| EmptyForIteratorPad | 0 | Error |
| MethodParamPad | 0 | Error |
| NoWhitespaceAfter | 0 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 0 | Error |
| ParenPad | 0 | Error |
| TypecastParenPad | 0 | Error |
| WhitespaceAfter | 18 | Error |
| WhitespaceAround | 3 | Error |
| ModifierOrder | 2 | Error |
| RedundantModifier | 10 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
| LeftCurly | 0 | Error |
| NeedBraces | 11 | Error |
| RightCurly | 0 | Error |
| AvoidInlineConditionals | 3 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsHashCode | 0 | Error |
| HiddenField | 0 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 8 | Error |
| MissingSwitchDefault | 0 | Error |
| RedundantThrows | 0 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| DesignForExtension | 33 | Error |
| FinalClass | 0 | Error |
| HideUtilityClassConstructor | 1 | Error |
| InterfaceIsType | 0 | Error |
| VisibilityModifier | 2 | Error |
| ArrayTypeStyle | 0 | Error |
| FinalParameters | 35 | Error |
| TodoComment | 0 | Error |
| UpperEll | 0 | Error |
Details
org/treetank/access/IscsiReadTrx.java
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 |
| Line has trailing spaces. | 4 |
| Line has trailing spaces. | 15 |
| Line is longer than 80 characters. | 16 |
| Line has trailing spaces. | 38 |
| Variable 'mPageReadTrx' must be private and have accessor methods. | 43 |
| Line has trailing spaces. | 50 |
| Line has trailing spaces. | 51 |
| 'cast' is not followed by whitespace. | 59 |
| Method 'moveTo' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter pKey should be final. | 66 |
| 'cast' is not followed by whitespace. | 68 |
| Method 'getValueOfCurrentData' is not designed for extension - needs to be abstract, final or empty. | 78 |
| 'if' construct must use '{}'s. | 80 |
| 'cast' is not followed by whitespace. | 83 |
| Method 'getCurrentData' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Method 'isClosed' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Line has trailing spaces. | 112 |
| Line is longer than 80 characters. | 116 |
org/treetank/access/IscsiWriteTrx.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 47 |
| Line has trailing spaces. | 49 |
| Line is longer than 80 characters. | 56 |
| Parameter pPageTrx should be final. | 56 |
| Parameter pSession should be final. | 56 |
| Expected @throws tag for 'TTException'. | 56 |
| Method 'bootstrap' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter bytes should be final. | 66 |
| Line is longer than 80 characters. | 67 |
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Parameter val should be final. | 84 |
| '=' is not preceded with whitespace. | 86 |
| Method 'commit' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Line is longer than 80 characters. | 108 |
| Method 'abort' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Method 'moveTo' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Parameter pKey should be final. | 134 |
| Method 'getValueOfCurrentData' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Method 'getCurrentData' is not designed for extension - needs to be abstract, final or empty. | 151 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 159 |
| 'if' construct must use '{}'s. | 162 |
| Method 'isClosed' is not designed for extension - needs to be abstract, final or empty. | 169 |
| Line has trailing spaces. | 177 |
| 'cast' is not followed by whitespace. | 182 |
org/treetank/api/IIscsiReadTrx.java
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 |
| Line has trailing spaces. | 4 |
| Line has trailing spaces. | 15 |
| Line is longer than 80 characters. | 16 |
| Line has trailing spaces. | 34 |
| Line has trailing spaces. | 36 |
| First sentence should end with a period. | 40 |
| Line has trailing spaces. | 42 |
| Redundant 'public' modifier. | 46 |
| Expected @param tag for 'pKey'. | 46 |
| Line has trailing spaces. | 50 |
| Redundant 'public' modifier. | 53 |
| First sentence should end with a period. | 55 |
| Line has trailing spaces. | 57 |
| Redundant 'public' modifier. | 60 |
| First sentence should end with a period. | 62 |
| Line has trailing spaces. | 64 |
| Redundant 'public' modifier. | 67 |
| Expected @throws tag for 'TTIOException'. | 67 |
| First sentence should end with a period. | 69 |
| Line has trailing spaces. | 71 |
| Redundant 'public' modifier. | 74 |
org/treetank/api/IIscsiWriteTrx.java
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 4 |
| Line has trailing spaces. | 15 |
| Line is longer than 80 characters. | 16 |
| First sentence should end with a period. | 32 |
| Line has trailing spaces. | 34 |
| Line has trailing spaces. | 42 |
| Line has trailing spaces. | 43 |
| Redundant 'public' modifier. | 46 |
| Expected @throws tag for 'TTException'. | 46 |
| Line has trailing spaces. | 50 |
| Line has trailing spaces. | 53 |
| Redundant 'public' modifier. | 56 |
| Line is longer than 80 characters. | 59 |
| Line has trailing spaces. | 61 |
| Redundant 'public' modifier. | 65 |
| Line has trailing spaces. | 69 |
| Redundant 'public' modifier. | 72 |
org/treetank/data/BlockDataElement.java
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 |
| Line has trailing spaces. | 38 |
| Line has trailing spaces. | 44 |
| Line has trailing spaces. | 46 |
| Missing a Javadoc comment. | 49 |
| Missing a Javadoc comment. | 50 |
| Parameter data should be final. | 50 |
| Parameter into should be final. | 50 |
| 'cast' is not followed by whitespace. | 51 |
| Line is longer than 80 characters. | 63 |
| Line is longer than 80 characters. | 64 |
| First sentence should end with a period. | 74 |
| Line has trailing spaces. | 76 |
| Parameter pDataKey should be final. | 80 |
| Expected @param tag for 'pDataKey'. | 80 |
| Parameter pContent should be final. | 80 |
| Expected @param tag for 'pContent'. | 80 |
| First sentence should end with a period. | 86 |
| Line has trailing spaces. | 88 |
| Method 'serialize' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Expected @throws tag for 'TTIOException'. | 93 |
| Method 'getDataKey' is not designed for extension - needs to be abstract, final or empty. | 103 |
| Line has trailing spaces. | 111 |
| Method 'getVal' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Line has trailing spaces. | 120 |
| Method 'setVal' is not designed for extension - needs to be abstract, final or empty. | 123 |
| Parameter pVal should be final. | 123 |
| Expected @param tag for 'pVal'. | 123 |
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 130 |
| 'cast' is not followed by whitespace. | 134 |
| '32' is a magic number. | 134 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Parameter obj should be final. | 143 |
| 'if' construct must use '{}'s. | 144 |
| 'if' construct must use '{}'s. | 146 |
| 'if' construct must use '{}'s. | 148 |
| 'cast' is not followed by whitespace. | 150 |
| 'if' construct must use '{}'s. | 151 |
| 'if' construct must use '{}'s. | 153 |
| Method 'getFunnel' is not designed for extension - needs to be abstract, final or empty. | 161 |
org/treetank/data/BlockDataElementFactory.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 34 |
| Line has trailing spaces. | 36 |
| Line has trailing spaces. | 43 |
| Method 'deserializeData' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter input should be final. | 46 |
org/treetank/data/ISCSIMetaPageFactory.java
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 14 |
| Line has trailing spaces. | 16 |
| Method 'deserializeEntry' is not designed for extension - needs to be abstract, final or empty. | 20 |
| Parameter pData should be final. | 21 |
| Parameter pOutput should be final. | 24 |
org/treetank/jscsi/HybridTreetankStorageModule.java
| Violation | Message | Line |
|---|---|---|
| Missing package-info.java file. | 0 |
| Line has trailing spaces. | 52 |
| Line has trailing spaces. | 60 |
| 'static' modifier out of order with the JLS suggestions. | 73 |
| Line is longer than 80 characters. | 75 |
| Missing a Javadoc comment. | 75 |
| First sentence should end with a period. | 77 |
| Line has trailing spaces. | 80 |
| First sentence should end with a period. | 101 |
| Line is longer than 80 characters. | 101 |
| First sentence should end with a period. | 104 |
| Line has trailing spaces. | 109 |
| Line is longer than 80 characters. | 117 |
| Line is longer than 80 characters. | 121 |
| Line is longer than 80 characters. | 127 |
| Line has trailing spaces. | 136 |
| Unused @throws tag for 'IOException'. | 137 |
| Expected @throws tag for 'TTException'. | 141 |
| Line is longer than 80 characters. | 143 |
| Line is longer than 80 characters. | 144 |
| Line is longer than 80 characters. | 148 |
| Line is longer than 80 characters. | 159 |
| Line is longer than 80 characters. | 160 |
| Line is longer than 80 characters. | 169 |
| Method 'checkBounds' is not designed for extension - needs to be abstract, final or empty. | 169 |
| Parameter logicalBlockAddress should be final. | 169 |
| Parameter transferLengthInBlocks should be final. | 169 |
| Line is longer than 80 characters. | 171 |
| Line is longer than 80 characters. | 177 |
| Method 'getSizeInBlocks' is not designed for extension - needs to be abstract, final or empty. | 187 |
| Method 'read' is not designed for extension - needs to be abstract, final or empty. | 195 |
| Parameter bytes should be final. | 195 |
| Parameter storageIndex should be final. | 195 |
| Line is longer than 80 characters. | 197 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 206 |
| Parameter bytes should be final. | 206 |
| Parameter storageIndex should be final. | 206 |
| Line is longer than 80 characters. | 208 |
| Line has trailing spaces. | 220 |
| Line has trailing spaces. | 222 |
| Missing a Javadoc comment. | 226 |
| Missing a Javadoc comment. | 227 |
| Missing a Javadoc comment. | 229 |
| Parameter pBytes should be final. | 229 |
| Parameter pStorageIndex should be final. | 229 |
| 'cast' is not followed by whitespace. | 237 |
| Line is longer than 80 characters. | 240 |
| 'cast' is not followed by whitespace. | 240 |
| Line is longer than 80 characters. | 243 |
| Avoid inline conditionals. | 243 |
| Line is longer than 80 characters. | 249 |
| Line is longer than 80 characters. | 255 |
| Line is longer than 80 characters. | 264 |
| Line is longer than 80 characters. | 270 |
| Line is longer than 80 characters. | 271 |
| Missing a Javadoc comment. | 292 |
| Missing a Javadoc comment. | 293 |
| Parameter r should be final. | 293 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 303 |
org/treetank/jscsi/TreetankConfiguration.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 52 |
| Line is longer than 80 characters. | 53 |
| Line has trailing spaces. | 56 |
| Line has trailing spaces. | 58 |
| Missing a Javadoc comment. | 62 |
| First sentence should end with a period. | 64 |
| Line has trailing spaces. | 66 |
| Line is longer than 80 characters. | 70 |
| Line is longer than 80 characters. | 73 |
| Expected @throws tag for 'IOException'. | 73 |
| First sentence should end with a period. | 78 |
| Line has trailing spaces. | 80 |
| Line is longer than 80 characters. | 85 |
| Line is longer than 80 characters. | 92 |
| Expected @param tag for 'schemaLocation'. | 92 |
| Expected @param tag for 'configFile'. | 92 |
| Line is longer than 80 characters. | 93 |
| Parameter session should be final. | 93 |
| Expected @param tag for 'session'. | 93 |
| Expected @throws tag for 'SAXException'. | 93 |
| Expected @throws tag for 'ParserConfigurationException'. | 93 |
| Expected @throws tag for 'IOException'. | 93 |
| Expected @throws tag for 'TTException'. | 93 |
| Line is longer than 80 characters. | 95 |
| Line is longer than 80 characters. | 101 |
| 'cast' is not followed by whitespace. | 110 |
| Line is longer than 80 characters. | 113 |
| Line is longer than 80 characters. | 115 |
| 'cast' is not followed by whitespace. | 115 |
| Line is longer than 80 characters. | 116 |
| Line is longer than 80 characters. | 117 |
| Line is longer than 80 characters. | 119 |
| 'cast' is not followed by whitespace. | 119 |
| 'if' construct must use '{}'s. | 127 |
| Line is longer than 80 characters. | 129 |
| 'else' construct must use '{}'s. | 130 |
| '3260' is a magic number. | 131 |
| 'if' construct must use '{}'s. | 136 |
| 'else' construct must use '{}'s. | 138 |
| Line is longer than 80 characters. | 140 |
| Line is longer than 80 characters. | 145 |
| Missing a Javadoc comment. | 145 |
| Redundant 'final' modifier. | 145 |
| Parameter targetElement should be final. | 145 |
| Parameter conf should be final. | 145 |
| Line is longer than 80 characters. | 183 |
| Line is longer than 80 characters. | 185 |
| '1024' is a magic number. | 185 |
| '3' is a magic number. | 185 |
| Line has trailing spaces. | 188 |
| Line is longer than 80 characters. | 189 |
| Line has trailing spaces. | 191 |
| Line is longer than 80 characters. | 192 |
| Line has trailing spaces. | 194 |
org/treetank/jscsi/TreetankStorageModule.java
| Violation | Message | Line |
|---|---|---|
| Line has trailing spaces. | 47 |
| Line has trailing spaces. | 57 |
| Line is longer than 80 characters. | 58 |
| Line is longer than 80 characters. | 60 |
| Line is longer than 80 characters. | 61 |
| 'static' modifier out of order with the JLS suggestions. | 70 |
| Line is longer than 80 characters. | 72 |
| Missing a Javadoc comment. | 72 |
| First sentence should end with a period. | 74 |
| Line is longer than 80 characters. | 75 |
| Line has trailing spaces. | 77 |
| Line is longer than 80 characters. | 94 |
| Missing a Javadoc comment. | 98 |
| Variable 'mPrefetchedBuckets' must be private and have accessor methods. | 98 |
| Missing a Javadoc comment. | 99 |
| Name 'BUCKETS_TO_PREFETCH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 99 |
| '3' is a magic number. | 99 |
| Line has trailing spaces. | 103 |
| Line is longer than 80 characters. | 111 |
| Line is longer than 80 characters. | 116 |
| Line has trailing spaces. | 129 |
| Unused @throws tag for 'IOException'. | 130 |
| Line is longer than 80 characters. | 131 |
| Expected @throws tag for 'TTException'. | 133 |
| Line is longer than 80 characters. | 135 |
| Line is longer than 80 characters. | 136 |
| Line is longer than 80 characters. | 146 |
| Line is longer than 80 characters. | 157 |
| Method 'checkBounds' is not designed for extension - needs to be abstract, final or empty. | 157 |
| Parameter logicalBlockAddress should be final. | 157 |
| Parameter transferLengthInBlocks should be final. | 157 |
| Line is longer than 80 characters. | 159 |
| Line is longer than 80 characters. | 162 |
| Line is longer than 80 characters. | 164 |
| Method 'getSizeInBlocks' is not designed for extension - needs to be abstract, final or empty. | 174 |
| Method 'read' is not designed for extension - needs to be abstract, final or empty. | 182 |
| Parameter bytes should be final. | 182 |
| Parameter storageIndex should be final. | 182 |
| Line is longer than 80 characters. | 183 |
| 'cast' is not followed by whitespace. | 187 |
| 'cast' is not followed by whitespace. | 191 |
| Line is longer than 80 characters. | 199 |
| Avoid inline conditionals. | 199 |
| Line is longer than 80 characters. | 225 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 232 |
| Parameter bytes should be final. | 232 |
| Parameter storageIndex should be final. | 232 |
| Line is longer than 80 characters. | 233 |
| 'cast' is not followed by whitespace. | 237 |
| 'cast' is not followed by whitespace. | 240 |
| Line is longer than 80 characters. | 243 |
| Avoid inline conditionals. | 243 |
| Line is longer than 80 characters. | 281 |
| Line is longer than 80 characters. | 300 |
| First sentence should end with a period. | 307 |
| Parameter storageIndex should be final. | 310 |
| Expected @param tag for 'storageIndex'. | 310 |
| '128' is a magic number. | 313 |
| '128' is a magic number. | 321 |
| '128' is a magic number. | 326 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 333 |
org/treetank/jscsi/TreetankTargetServer.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 43 |
| Unused import - org.treetank.io.berkeley.BerkeleyStorage. | 53 |
| Unused import - com.google.common.io.Files. | 58 |
| Line has trailing spaces. | 64 |
| Line has trailing spaces. | 66 |
| Utility classes should not have a public or default constructor. | 68 |
| Line has trailing spaces. | 72 |
| Line is longer than 80 characters. | 74 |
| Line is longer than 80 characters. | 75 |
| Line has trailing spaces. | 77 |
| Line is longer than 80 characters. | 79 |
| Line is longer than 80 characters. | 81 |
| Line is longer than 80 characters. | 83 |
| Line is longer than 80 characters. | 86 |
| Line has trailing spaces. | 87 |
| Parameter args should be final. | 91 |
| Expected @throws tag for 'Exception'. | 91 |
| Line is longer than 80 characters. | 115 |
| Line is longer than 80 characters. | 117 |
| Line is longer than 80 characters. | 128 |
| Line is longer than 80 characters. | 143 |
| Line is longer than 80 characters. | 153 |
| Line contains a tab character. | 160 |
| Line is longer than 80 characters. | 162 |
| Line is longer than 80 characters. | 163 |
| Line is longer than 80 characters. | 173 |
| 'cast' is not followed by whitespace. | 173 |
| Line is longer than 80 characters. | 180 |
| 'cast' is not followed by whitespace. | 180 |
| Line has trailing spaces. | 184 |
| '=' is not preceded with whitespace. | 188 |
| '=' is not followed by whitespace. | 188 |
| Line has trailing spaces. | 189 |
| Line is longer than 80 characters. | 192 |
| Line is longer than 80 characters. | 193 |
| Line is longer than 80 characters. | 197 |
| Line is longer than 80 characters. | 202 |
| Line is longer than 80 characters. | 205 |
| Missing a Javadoc comment. | 211 |
| Line is longer than 80 characters. | 224 |
| Line is longer than 80 characters. | 230 |
| Line is longer than 80 characters. | 235 |
| Line is longer than 80 characters. | 240 |
| Line is longer than 80 characters. | 243 |